Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test modules ACL support #4042

Merged
merged 7 commits into from
Jan 30, 2025
Merged

Test modules ACL support #4042

merged 7 commits into from
Jan 30, 2025

Conversation

sazzad16
Copy link
Collaborator

No description provided.

@sazzad16 sazzad16 requested review from uglide and ggivo January 22, 2025 16:50
@sazzad16 sazzad16 added this to the 6.0.0 milestone Jan 23, 2025
@sazzad16 sazzad16 marked this pull request as ready for review January 23, 2025 10:20
ggivo
ggivo previously approved these changes Jan 28, 2025
Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The Integration test job is failing since it is bootstrapping test env from unstable branch (being 7.9) but by default it is build without modules.

Should we consider migrating completely to containerised env?

Copy link
Contributor

@ggivo ggivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sazzad16 sazzad16 merged commit 5e1b5c8 into redis:master Jan 30, 2025
8 checks passed
@sazzad16 sazzad16 deleted the modules-acl branch January 30, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants